Repository navigation
fix(engine): data-URI background-image 不再跳过——SVG 图标/壁纸走 fetch+cache（C4 根因） - #141
Merged
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: d232fc72-5496-438f-adb6-6c407af4ce15) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Visibility-only API change with no logic edits; risk is limited to new internal callers if added elsewhere in the crate.
Overview
This PR makes a single visibility change:
collect_custom_propsinasync_load.rsis nowpub(crate)instead of module-private.Behavior of the scanner is unchanged—it still walks CSS text, collects
--custom-property: valuepairs inside rule blocks, and feeds the existingsubstitute_css_vars_textpath before budgeted render. The change only allows other code in thewebviewcrate to reuse that collector without duplicating the parser (aligned with the bing-t5 C3/C4 work around CSS custom properties andvar()substitution).There are no call-site updates in this diff; runtime behavior should be identical unless another crate module starts calling the function in the same branch.
Reviewed by Cursor Bugbot for commit 0620e81. Bugbot is set up for automated code reviews on this repo. Configure here.